Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize BasinRenderer #7124

Open
wants to merge 1 commit into
base: mc1.20.1/dev
Choose a base branch
from
Open

Optimize BasinRenderer #7124

wants to merge 1 commit into from
+53 −46

Conversation

MoePus
Copy link
Contributor

@MoePus MoePus commented Nov 4, 2024

  • Do not render items and fluids if basin is higher than player
  • Do not get ChunkAccess if there is no visualizedOutputItems

@IThundxr IThundxr added the area: rendering Issue or PR is related to rendering label Nov 4, 2024
@MoePus MoePus marked this pull request as draft January 22, 2025 07:36
@MoePus
Copy link
Contributor Author

MoePus commented Jan 31, 2025

Breaks basin on contraptions

@MoePus MoePus closed this Jan 31, 2025
@VoidLeech
Copy link
Collaborator

In the same way that you did instanceof PonderWorld, could you not add instanceof ContraptionWorld too, or does that still break them? (Or probably better: just instanceof WrapperWorld)

@MoePus
Copy link
Contributor Author

MoePus commented Jan 31, 2025

In the same way that you did instanceof PonderWorld, could you not add instanceof ContraptionWorld too, or does that still break them? (Or probably better: just instanceof WrapperWorld)

Yes you are right... i was stuck on making this code compatible with contraptions

@MoePus MoePus reopened this Jan 31, 2025
@MoePus MoePus force-pushed the mc1.20.1/optimize-basin-renderer branch from 5544a69 to 4ecc18e Compare January 31, 2025 15:01
@MoePus MoePus marked this pull request as ready for review January 31, 2025 15:01
@MoePus MoePus force-pushed the mc1.20.1/optimize-basin-renderer branch from 4ecc18e to 1878001 Compare January 31, 2025 15:16
@VoidLeech VoidLeech added the pr status: conflicts PR has merge conflicts label Mar 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025

@MoePus, this pull request has merge conflicts with the target branch. Please merge the latest changes and leave a message here so we can continue with the process of reviewing and merging this pull request. Thanks!

@MoePus
Optimize BasinRenderer
7063773 
* Do not render items and fluids if basin is higher than player
* Do not get ChunkAccess if there is no visualizedOutputItems
@MoePus MoePus force-pushed the mc1.20.1/optimize-basin-renderer branch from 1878001 to 7063773 Compare March 5, 2025 12:56
@MoePus
Copy link
Contributor Author

MoePus commented Mar 5, 2025

@MoePus, this pull request has merge conflicts with the target branch. Please merge the latest changes and leave a message here so we can continue with the process of reviewing and merging this pull request. Thanks!

conflict fixed

@VoidLeech VoidLeech removed the pr status: conflicts PR has merge conflicts label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: rendering Issue or PR is related to rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MoePus @VoidLeech @IThundxr