Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] dive deeper to picture #204

Merged
merged 22 commits into from
Jan 24, 2024
Merged

[Android] dive deeper to picture #204

merged 22 commits into from
Jan 24, 2024

Conversation

arifBurakDemiray
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited
Loading

Unit Test Results 🚀

449 tests   - 1   449 ✅  - 1   1m 34s ⏱️ -3s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 0d677d2. ± Comparison against base commit 6d58408.

♻️ This comment has been updated with latest results.

turtledreams
turtledreams requested changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@turtledreams turtledreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more comments pls (onegai)

ArtursKadikis
ArtursKadikis requested changes Jan 22, 2024
View reviewed changes
Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let us split this up in multiple steps

ArtursKadikis
ArtursKadikis requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

divide the addMultipart function in 2.
try to approximate the used data size for the multipart function

ArtursKadikis
ArtursKadikis requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url encoded things

@arifBurakDemiray
Copy link
Member Author

url encoded things

This is not possible, I have spoken with server and things should stay decoded

@ArtursKadikis ArtursKadikis merged commit 411d506 into staging Jan 24, 2024
2 of 3 checks passed
@ArtursKadikis ArtursKadikis deleted the picture_rework branch January 24, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turtledreams turtledreams Awaiting requested review from turtledreams turtledreams is a code owner

@ArtursKadikis ArtursKadikis Awaiting requested review from ArtursKadikis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arifBurakDemiray @ArtursKadikis @turtledreams