-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Validate gradle wrapper and update gradle scripts #115
Conversation
I guess you have to enable Github actions |
When you enable Github actions, you will see your gradle jar file has a wrong checksum https://github.com/hannesa2/countly-sdk-android/pull/1/checks?check_run_id=876276329 |
To generate and add a gradle wrapper -> https://stackoverflow.com/a/25770202 |
name: "Validation" | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update the versions
@@ -37,7 +37,7 @@ android { | |||
path file('src/main/cpp/CMakeLists.txt') | |||
} | |||
} | |||
ndkVersion '21.0.6113669' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please open a different pr for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let us discuss this. I will write back here after discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some things to consider
Sorry to say this. After 3 (!) years of silence, my focus is now somewhere else. I work for other topics and projects now. See it as suggestion. |
Hello, we merged a modified version of this. |
This is the full story https://github.com/gradle/wrapper-validation-action#the-gradle-wrapper-problem-in-open-source