Merge pull request #209 from Countly/default_warn

[Android] Add warnings to all SDK example apps that would check if propper credentials have been set or it still has the defaults.
Countly · Jan 29, 2024 · 5a87771 · 5a87771
2 parents b4f6630 + 60d8a03
commit 5a87771
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 7 deletions.
diff --git a/app-kotlin/src/main/java/ly/count/android/demo/kotlin/App.kt b/app-kotlin/src/main/java/ly/count/android/demo/kotlin/App.kt
@@ -4,15 +4,19 @@ import android.app.Application
 import android.util.Log
 import ly.count.android.sdk.Countly
 import ly.count.android.sdk.CountlyConfig
-import ly.count.android.sdk.RemoteConfigCallback
 
 //import ly.count.android.sdk.DeviceIdType
 
 class App : Application() {
-  val COUNTLY_SERVER_URL = "YOUR_SERVER_URL"
+  val COUNTLY_SERVER_URL = "https://your.server.ly"
   val COUNTLY_APP_KEY = "YOUR_APP_KEY"
   override fun onCreate() {
     super.onCreate()
+
+    if (COUNTLY_SERVER_URL == "https://your.server.ly" || COUNTLY_APP_KEY == "YOUR_APP_KEY") {
+      Log.e("CountlyDemo", "Please provide correct COUNTLY_SERVER_URL and COUNTLY_APP_KEY")
+      return
+    }    
 
     val countlyConfig = CountlyConfig(
       this,
@@ -29,4 +33,4 @@ class App : Application() {
 
     Countly.sharedInstance().init(countlyConfig)
   }
-}
+}
diff --git a/app-native/src/main/java/ly/count/android/demo/crash/App.java b/app-native/src/main/java/ly/count/android/demo/crash/App.java
@@ -1,17 +1,24 @@
 package ly.count.android.demo.crash;
 
 import android.app.Application;
+import android.util.Log;
 import ly.count.android.sdk.Countly;
 import ly.count.android.sdk.CountlyConfig;
 import ly.count.android.sdknative.CountlyNative;
 
 public class App extends Application {
 
-    final String COUNTLY_SERVER_URL = "https://try.count.ly";
-    final String COUNTLY_APP_KEY = "xxxxxxx";
+    final String COUNTLY_SERVER_URL = "https://your.server.ly";
+    final String COUNTLY_APP_KEY = "YOUR_APP_KEY";
 
     @Override public void onCreate() {
         super.onCreate();
+
+        if (COUNTLY_SERVER_URL.equals("https://your.server.ly") || COUNTLY_APP_KEY.equals("YOUR_APP_KEY")) {
+            Log.e("CountlyCrashDemo", "Please provide correct COUNTLY_SERVER_URL and COUNTLY_APP_KEY");
+            return;
+        }
+
         Countly.applicationOnCreate();
 
         CountlyConfig config = (new CountlyConfig(this, COUNTLY_APP_KEY, COUNTLY_SERVER_URL)).setDeviceId("4432")
@@ -23,4 +30,4 @@ public class App extends Application {
 
         CountlyNative.initNative(getApplicationContext());
     }
-}
+}
diff --git a/app/src/main/java/ly/count/android/demo/App.java b/app/src/main/java/ly/count/android/demo/App.java
@@ -34,7 +34,7 @@
 
 public class App extends Application {
     /** You should use try.count.ly instead of YOUR_SERVER for the line below if you are using Countly trial service */
-    final String COUNTLY_SERVER_URL = "YOUR_SERVER";
+    final String COUNTLY_SERVER_URL = "https://your.server.ly";
     final String COUNTLY_APP_KEY = "YOUR_APP_KEY";
     static long applicationStartTimestamp = System.currentTimeMillis();
 
@@ -44,6 +44,11 @@ public class App extends Application {
     public void onCreate() {
         super.onCreate();
 
+        if (COUNTLY_SERVER_URL.equals("https://your.server.ly") || COUNTLY_APP_KEY.equals("YOUR_APP_KEY")) {
+            Log.e("CountlyDemo", "Please provide correct COUNTLY_SERVER_URL and COUNTLY_APP_KEY");
+            return;
+        }
+
         if (false) {
             //setting up strict mode for additional validation
             StrictMode.setThreadPolicy(new StrictMode.ThreadPolicy.Builder()