-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typo check to CI #2032
Add typo check to CI #2032
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2032 +/- ##
==========================================
+ Coverage 42.85% 42.87% +0.01%
==========================================
Files 85 85
Lines 11587 11587
==========================================
+ Hits 4966 4968 +2
+ Misses 6180 6179 -1
+ Partials 441 440 -1
|
iNdEx = "iNdEx" | ||
|
||
[files] | ||
extend-exclude = ["**/go.mod", "**/go.sum", "**/*.pb.go"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some excludes here to avoid checking package hashes and generated files. There was already one false-positive in go.sum
.
extend-ignore-re = ["(?Rm)^.*(#|//)\\s*spellchecker:disable-line$"] | ||
|
||
[default.extend-identifiers] | ||
iNdEx = "iNdEx" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also added this, since it is used as a variable name in legacy_types.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have this in wasmd! LGTM 👍
CI config is copied from https://github.com/CosmWasm/cosmwasm/blob/main/.github/workflows/typo-check.yml