Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert reference-types support (backport #2311) #2316

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,11 @@ workflows:
matrix:
parameters:
# Run with MSRV and some modern stable Rust
<<<<<<< HEAD
rust-version: ["1.74.0", "1.82.0"]
=======
rust-version: ["1.74.0", "1.78.0"]
>>>>>>> f04587a1 (Revert "Update Rust CI version")
- benchmarking:
requires:
- package_vm
Expand Down Expand Up @@ -655,8 +659,7 @@ jobs:

contract_hackatom:
docker:
# We compile this contract with the upper bound to detect issues with new Rust versions early
- image: rust:1.82
- image: rust:1.74
environment:
RUST_BACKTRACE: 1
working_directory: ~/cosmwasm/contracts/hackatom
Expand All @@ -668,7 +671,7 @@ jobs:
command: rustc --version; cargo --version; rustup --version
- restore_cache:
keys:
- cargocache-v2-contract_hackatom-rust:1.82-{{ checksum "Cargo.lock" }}
- cargocache-v2-contract_hackatom-rust:1.74-{{ checksum "Cargo.lock" }}
- check_contract:
min_version: "2.2"
- save_cache:
Expand All @@ -680,7 +683,7 @@ jobs:
- target/wasm32-unknown-unknown/release/.fingerprint
- target/wasm32-unknown-unknown/release/build
- target/wasm32-unknown-unknown/release/deps
key: cargocache-v2-contract_hackatom-rust:1.82-{{ checksum "Cargo.lock" }}
key: cargocache-v2-contract_hackatom-rust:1.74-{{ checksum "Cargo.lock" }}

contract_ibc_callbacks:
docker:
Expand Down Expand Up @@ -1143,7 +1146,11 @@ jobs:

coverage:
docker:
<<<<<<< HEAD
- image: rust:1.82.0-alpine3.19
=======
- image: rust:1.78.0-alpine3.19
>>>>>>> f04587a1 (Revert "Update Rust CI version")
environment:
# Limit the number of parallel jobs to avoid OOM crashes during doc testing
RUST_TEST_THREADS: 8
Expand Down
7 changes: 4 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,12 @@ and this project adheres to
- cosmwasm-vm: Export a new `migrate_with_info` function ([#2212])
- cosmwasm-derive: Add support for migrate method with
`migrate_info: MigrateInfo` argument. ([#2212])
- cosmwasm-vm: Enable support for reference-types proposal, required since Rust
1.82 ([#2288])
- cosmwasm-vm: Add `Cache::store_code`

[#2118]: https://github.com/CosmWasm/cosmwasm/pull/2118
[#2196]: https://github.com/CosmWasm/cosmwasm/pull/2196
[#2220]: https://github.com/CosmWasm/cosmwasm/pull/2220
[#2212]: https://github.com/CosmWasm/cosmwasm/pull/2212
[#2288]: https://github.com/CosmWasm/cosmwasm/pull/2288

### Changed

Expand All @@ -52,12 +49,16 @@ and this project adheres to
match the contract address from `mock_env`. ([#2211])
- cosmwasm-derive: Automatically detect whether the package is a dependency or
the primary package, only expanding entrypoints for the primary package. This
<<<<<<< HEAD
effectively deprecates the usage of the `library` feature pattern.

Note: This feature does **NOT** interact well with workspaces due to a cargo
bug. If you have multiple contracts in a workspace, you might still want to
use the library feature ([#2246])

=======
effectively deprecates the usage of the `library` feature pattern. ([#2246])
>>>>>>> f04587a1 (Revert "Update Rust CI version")
- cosmwasm-std: Deprecate `BankQuery::AllBalances` and `IbcQuery::ListChannels`.
Both are inherently problematic to use because the returned entries are
unbounded. ([#2247])
Expand Down
36 changes: 36 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@ exclude = ["contracts"]
resolver = "2"

[workspace.package]
<<<<<<< HEAD
version = "2.2.0-rc.1"
=======
version = "2.2.0-rc.3"
>>>>>>> f04587a1 (Revert "Update Rust CI version")

[workspace.dependencies]
schemars = "0.8.4"
Expand Down
32 changes: 32 additions & 0 deletions contracts/burner/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 32 additions & 0 deletions contracts/crypto-verify/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading