Fix pubkey recovery to work with high/low s for k256 ^0.13.2 #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 1, 2024
webmaster128
force-pushed
the
add-wycheproof
branch
from
07e98dd to
fa92691
Compare
webmaster128
force-pushed
the
fix-pubkey-recovery-high-s
branch
from
f3ffcd0 to
88770e4
Compare
This was referenced Feb 2, 2024
webmaster128
force-pushed
the
fix-pubkey-recovery-high-s
branch
from
88770e4 to
c70c1ef
Compare
webmaster128
force-pushed
the
add-wycheproof
branch
from
5ecf3d3 to
0e9624a
Compare
webmaster128
force-pushed
the
fix-pubkey-recovery-high-s
branch
from
c70c1ef to
8fe308f
Compare
chipshort
approved these changes
Feb 5, 2024
|
Could this change be backported to the LTS (1.5) release? We're running into issues using cosmwasm with other tooling due to the |
|
@mergify backport release/1.5 |
✅ Backports have been created
|
|
Yeah, makes sense. Backport here: #2198. Will be shipped in the next patch release. |
webmaster128
added a commit
that referenced
this pull request
Aug 6, 2024
Fix pubkey recovery to work with high/low s for k256 ^0.13.2 (backport #2014)
|
Released in 1.5.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #2000 to get extra test coverage before marking the change. Merge #2000 first.Closes #2010