Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for primary keys where the field id is missing #707 #708

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

Jed-Giblin
Copy link
Contributor

@Jed-Giblin Jed-Giblin commented Nov 19, 2024

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc.)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issue(s)

Refs #707
Closes #707

Other Information

@Jed-Giblin Jed-Giblin marked this pull request as ready for review November 19, 2024 21:27
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.77%. Comparing base (2b2c385) to head (7e0b398).
Report is 116 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #708       +/-   ##
===========================================
+ Coverage   88.36%   99.77%   +11.40%     
===========================================
  Files          18       26        +8     
  Lines         619      901      +282     
  Branches      116      151       +35     
===========================================
+ Hits          547      899      +352     
+ Misses         62        1       -61     
+ Partials       10        1        -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Dresdn Dresdn merged commit e6e70b0 into Corvia:master Nov 21, 2024
11 checks passed
@Dresdn
Copy link
Collaborator

Dresdn commented Nov 21, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User model query filters on id instead of defined primary key field
2 participants