Fix multiple inheritance in Python 3.11 #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalanche/training/templates/observation_type/batch_observation.py
Outdated
Show resolved
Hide resolved
AntonioCarta
reviewed
Feb 5, 2024
tests/models/test_packnet.py
Outdated
| eval_mb_size=10, | ||
| device="cuda" if use_gpu else "cpu", | ||
| ) | ||
| with self.assertWarns(PositionalArgumentDeprecatedWarning): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the multiple inheritance issue in Python 3.11.
Strategy constructors now accept all arguments as keyword-only. The main elements of the class hierarchy now use a cooperative constructor mechanism. The deprecation of the previous positional-based mechanism is handled to allow users to use existing code (Avalanche will print a warning if positional arguments declared/used).
This also has an additional change to the coveralls action to align it to the unit-test one.