Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support num_workers in EWC #1310

Closed
wants to merge 3 commits into from
Closed

Conversation

WenjinW
Copy link

@WenjinW WenjinW commented Mar 3, 2023

No description provided.

@ContinualAI-bot
Copy link
Collaborator

Oh no! It seems there are some PEP8 errors! 😕
Don't worry, you can fix them! 💪
Here's a report about the errors and where you can find them:

avalanche/training/plugins/ewc.py:131:81: E501 line too long (83 > 80 characters)
avalanche/training/plugins/ewc.py:154:81: E501 line too long (88 > 80 characters)
tests/test_avalanche_dataset.py:2104:71: E741 ambiguous variable name 'l'
2       E501 line too long (83 > 80 characters)
1       E741 ambiguous variable name 'l'

@ContinualAI-bot
Copy link
Collaborator

Oh no! It seems there are some PEP8 errors! 😕
Don't worry, you can fix them! 💪
Here's a report about the errors and where you can find them:

avalanche/training/plugins/ewc.py:133:81: E501 line too long (83 > 80 characters)
avalanche/training/plugins/ewc.py:161:81: E501 line too long (91 > 80 characters)
avalanche/training/plugins/ewc.py:164:9: E122 continuation line missing indentation or outdented
avalanche/training/plugins/ewc.py:166:30: E251 unexpected spaces around keyword / parameter equals
avalanche/training/plugins/ewc.py:166:32: E251 unexpected spaces around keyword / parameter equals
avalanche/training/plugins/ewc.py:167:17: E251 unexpected spaces around keyword / parameter equals
avalanche/training/plugins/ewc.py:167:19: E251 unexpected spaces around keyword / parameter equals
avalanche/training/plugins/ewc.py:170:16: E251 unexpected spaces around keyword / parameter equals
avalanche/training/plugins/ewc.py:170:18: E251 unexpected spaces around keyword / parameter equals
avalanche/training/plugins/ewc.py:171:17: E251 unexpected spaces around keyword / parameter equals
avalanche/training/plugins/ewc.py:171:19: E251 unexpected spaces around keyword / parameter equals
avalanche/training/plugins/ewc.py:175:17: E113 unexpected indentation
avalanche/training/plugins/ewc.py:176:13: E901 IndentationError: unindent does not match any outer indentation level
1       E113 unexpected indentation
1       E122 continuation line missing indentation or outdented
8       E251 unexpected spaces around keyword / parameter equals
2       E501 line too long (83 > 80 characters)
1       E901 IndentationError: unindent does not match any outer indentation level

Fix pep8
@AntonioCarta
Copy link
Collaborator

Thanks. If you fix the pep8 we can merge this.

@lrzpellegrini
Copy link
Collaborator

Obtaining the number of workers using

num_workers=kwargs.get('num_workers', 0)

may be more general, as we are not sure that num_workers will exist in kwargs. Apart from that, it seems ok!

@WenjinW Can you update the PR? Otherwise, I can create a new PR for this!

lrzpellegrini added a commit to lrzpellegrini/avalanche that referenced this pull request Jun 7, 2023
@lrzpellegrini
Copy link
Collaborator

Added in #1463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants