Caching changes during block production #8773
Open
+124
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
StefanBratanov
changed the title
tbenr
reviewed
Oct 23, 2024
...java/tech/pegasys/teku/ethereum/executionlayer/ExecutionLayerBlockProductionManagerImpl.java
Outdated
Show resolved
Hide resolved
StefanBratanov
force-pushed
the
caching_changes
branch
from
9824908
to
152667e
Compare
tbenr
reviewed
Oct 23, 2024
beacon/validator/src/main/java/tech/pegasys/teku/validator/coordinator/ValidatorApiHandler.java
Outdated
Show resolved
Hide resolved
StefanBratanov
force-pushed
the
caching_changes
branch
from
f6da3d4
to
340a24d
Compare
tbenr
approved these changes
Oct 23, 2024
Comment on lines
+886
to
+892
| private boolean isLocallyCreatedBlock(final UInt64 slot) { | ||
| final SafeFuture<Optional<BlockContainerAndMetaData>> localBlockProduction = | ||
| localBlockProductionBySlotCache.get(slot); | ||
| if (localBlockProduction == null) { | ||
| return false; | ||
| } | ||
| return localBlockProduction.isCompletedNormally(); |
There was a problem hiding this comment.
I'd keep the blockRoot check here.
like
if (localBlockProduction == null) {
return false;
}
if(! localBlockProduction.isCompletedNormally()) {
return false;
}
return localBlockProduction.join() .... .equals(.....));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Essentially, return the same block if the createBlock endpoint is called twice. This means we no longer require the changes in #8766
Fixed Issue(s)
fixes #8625
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog