create EphemerySlotValidationService and test #8759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gconnect <[email protected]>
|
@rolfyone please review |
rolfyone
reviewed
Oct 21, 2024
Comment on lines
+34
to
+37
| final UInt64 currentSlot = | ||
| recentChainData | ||
| .getCurrentSlot() | ||
| .orElseThrow(() -> new IllegalStateException("Current slot not available")); |
There was a problem hiding this comment.
the slot comes into the function, you can just use that..
There was a problem hiding this comment.
Not sure what you meant
There was a problem hiding this comment.
onSlot(final UInt slot) {
The slot is the slot we're entering... we don't need to grab it from recentChainData, it's passed in.
rolfyone
reviewed
Oct 21, 2024
.../beaconchain/src/main/java/tech/pegasys/teku/services/beaconchain/BeaconChainController.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Todo
Fixed Issue(s)
fixes #8589