Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: two steps deployment github workflow #362

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

khanti42
Copy link
Collaborator

@khanti42 khanti42 commented Oct 1, 2024

closes: #361

@khanti42 khanti42 requested a review from a team as a code owner October 1, 2024 12:44
@khanti42 khanti42 requested review from Akaryatrh and jonesho and removed request for a team October 1, 2024 12:44
Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stanleyyconsensys
Copy link
Collaborator

it looks like some params didnt setup correctly, and some step is missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Split the Deployment Workflow into Two Stages
2 participants