Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SNAP): add StarkScan client to fetch transaction history #341

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

feat(SNAP): add StarkScan client to fetch transaction history #341

wants to merge 13 commits into from

Conversation

stanleyyconsensys
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys commented Sep 2, 2024 •
edited
Loading

This PR is adding a client sdk to fetch the transaction history with StarkScan

This is the first journey to enable fetching transaction by StarkScan

Hence, this PR will not apply the client to the getTransactions rpc

This PR includes:

  • a starkscan data client to enable:
    • getTransactions (by address , by till to timestamp)
    • getDeployTransaction (by address)
  • a dataClient interface to high level caller / object, doesnt need to know the detail on low level object (StarkScanClient)

@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner September 2, 2024 07:12
@stanleyyconsensys stanleyyconsensys requested review from Julink-eth and wantedsystem and removed request for a team September 2, 2024 07:12
@stanleyyconsensys stanleyyconsensys mentioned this pull request Sep 5, 2024
Draft
1 task
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stanleyyconsensys stanleyyconsensys changed the title feat: add StarkScan client to fetch transaction history feat(StarkScan): add StarkScan client to fetch transaction history Oct 8, 2024
@stanleyyconsensys stanleyyconsensys changed the title feat(StarkScan): add StarkScan client to fetch transaction history feat(SNAP): add StarkScan client to fetch transaction history Oct 22, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stanleyyconsensys stanleyyconsensys marked this pull request as draft October 22, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julink-eth Julink-eth Awaiting requested review from Julink-eth Julink-eth is a code owner automatically assigned from Consensys/snaps-factory-reviewers

@wantedsystem wantedsystem Awaiting requested review from wantedsystem wantedsystem is a code owner automatically assigned from Consensys/snaps-factory-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stanleyyconsensys