Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limiting number of concurrent traces API requests for the local stack… #236

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Filter94
Copy link
Collaborator

… to avoid occasional OOM-s

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

Copy link
Collaborator

@jpnovais jpnovais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to me. Please just check if it does not slow down the e2e tests

@Filter94
Copy link
Collaborator Author

Ok to me. Please just check if it does not slow down the e2e tests

Of course, I will give it a couple of tries

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.54%. Comparing base (00ffc73) to head (1d95a03).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #236      +/-   ##
============================================
- Coverage     70.76%   70.54%   -0.23%     
  Complexity     1074     1074              
============================================
  Files           298      300       +2     
  Lines         12070    12108      +38     
  Branches       1068     1073       +5     
============================================
  Hits           8541     8541              
- Misses         3049     3087      +38     
  Partials        480      480              
Flag Coverage Δ *Carryforward flag
hardhat 98.67% <ø> (ø) Carriedforward from 00ffc73
kotlin 68.25% <ø> (-0.24%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 4 files with indirect coverage changes

@Filter94 Filter94 temporarily deployed to docker-build-and-e2e October 23, 2024 14:43 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants