Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinator: Shared State Manager Client #233

Merged
merged 16 commits into from
Oct 23, 2024
Merged

Conversation

jpnovais
Copy link
Collaborator

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@jpnovais jpnovais requested a review from a team October 22, 2024 22:41
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 88 lines in your changes missing coverage. Please review.

Project coverage is 70.25%. Comparing base (00ffc73) to head (00a1300).
Report is 1 commits behind head on main.

Current head 00a1300 differs from pull request most recent head ccc15aa

Please upload reports for the commit ccc15aa to get more accurate results.

Files with missing lines Patch % Lines
...build/linea/clients/StateManagerV1JsonRpcClient.kt 0.00% 51 Missing ⚠️
...kotlin/build/linea/clients/StateManagerClientV1.kt 0.00% 29 Missing ⚠️
...face/src/main/kotlin/build/linea/clients/Client.kt 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #233      +/-   ##
============================================
- Coverage     70.76%   70.25%   -0.52%     
  Complexity     1074     1074              
============================================
  Files           298      301       +3     
  Lines         12070    12158      +88     
  Branches       1068     1079      +11     
============================================
  Hits           8541     8541              
- Misses         3049     3137      +88     
  Partials        480      480              
Flag Coverage Δ *Carryforward flag
hardhat 98.67% <ø> (ø) Carriedforward from 1aac2e9
kotlin 67.95% <0.00%> (-0.54%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...face/src/main/kotlin/build/linea/clients/Client.kt 0.00% <0.00%> (ø)
...kotlin/build/linea/clients/StateManagerClientV1.kt 0.00% <0.00%> (ø)
...build/linea/clients/StateManagerV1JsonRpcClient.kt 0.00% <0.00%> (ø)

jonesho
jonesho previously approved these changes Oct 23, 2024
# Conflicts:
#	jvm-libs/generic/extensions/kotlin/src/test/kotlin/build/linea/URIExtensionsTest.kt
#	jvm-libs/generic/vertx-helper/src/main/kotlin/net/consensys/linea/vertx/ClientOptions.kt
#	jvm-libs/linea/blob-decompressor/src/test/kotlin/net/consensys/linea/blob/BlobDecompressorDataDecodingTest.kt
#	jvm-libs/linea/blob-decompressor/src/test/kotlin/net/consensys/linea/blob/GoNativeBlobDecompressorTest.kt
Filter94
Filter94 previously approved these changes Oct 23, 2024
Base automatically changed from coordinator-code-reuse-3 to main October 23, 2024 09:36
@jpnovais jpnovais dismissed stale reviews from Filter94 and jonesho October 23, 2024 09:36

The base branch was changed.

@jpnovais jpnovais merged commit baffb9c into main Oct 23, 2024
10 of 12 checks passed
@jpnovais jpnovais deleted the coordinator-code-reuse-4 branch October 23, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants