Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinator: carve out BlockInterval #231

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Conversation

jpnovais
Copy link
Collaborator

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@jpnovais jpnovais requested a review from a team October 22, 2024 20:22
@jpnovais jpnovais changed the base branch from main to coordinator-code-reuse-1 October 22, 2024 20:23
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 68.08511% with 15 lines in your changes missing coverage. Please review.

Project coverage is 70.96%. Comparing base (ecfe183) to head (d40aa4d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rc/main/kotlin/build/linea/domain/BlockInterval.kt 78.04% 7 Missing and 2 partials ⚠️
...otlin/src/main/kotlin/build/linea/UrlExtensions.kt 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #231      +/-   ##
============================================
+ Coverage     70.82%   70.96%   +0.13%     
- Complexity     1074     1076       +2     
============================================
  Files           296      298       +2     
  Lines         12055    12070      +15     
  Branches       1063     1068       +5     
============================================
+ Hits           8538     8565      +27     
+ Misses         3038     3026      -12     
  Partials        479      479              
Flag Coverage Δ *Carryforward flag
hardhat 98.67% <ø> (ø) Carriedforward from ecfe183
kotlin 68.70% <68.08%> (+0.14%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...coordinator/clients/prover/ABProverClientRouter.kt 100.00% <ø> (ø)
...tor/clients/prover/GenericFileBasedProverClient.kt 89.42% <ø> (ø)
.../coordinator/clients/prover/ProverClientFactory.kt 60.34% <ø> (ø)
...rover/serialization/BlobJsonFileRequestResponse.kt 48.17% <ø> (ø)
...tor/clients/BatchExecutionProverRequestResponse.kt 44.44% <ø> (ø)
...or/clients/BlobCompressionProverRequestResponse.kt 55.78% <ø> (ø)
...n/kotlin/net/consensys/zkevm/domain/Aggregation.kt 47.82% <ø> (ø)
...src/main/kotlin/net/consensys/zkevm/domain/Blob.kt 56.00% <ø> (ø)
...in/kotlin/net/consensys/zkevm/domain/Conflation.kt 61.01% <ø> (-9.32%) ⬇️
...in/kotlin/net/consensys/zkevm/domain/ProofIndex.kt 42.10% <ø> (ø)
... and 15 more

... and 3 files with indirect coverage changes

jonesho
jonesho previously approved these changes Oct 23, 2024
Base automatically changed from coordinator-code-reuse-1 to main October 23, 2024 08:45
@jpnovais jpnovais dismissed jonesho’s stale review October 23, 2024 08:45

The base branch was changed.

@jpnovais jpnovais merged commit 00ffc73 into main Oct 23, 2024
11 of 12 checks passed
@jpnovais jpnovais deleted the coordinator-code-reuse-2 branch October 23, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants