Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/clean polynomial #476

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Feat/clean polynomial #476

wants to merge 10 commits into from

Conversation

ThomasPiellard
Copy link
Contributor

@ThomasPiellard ThomasPiellard commented Jan 9, 2024

Description

iop.Polynomial:

  • removed blinding -> easier to deal with blinding manually with KZG(blinded(p)) = Kzg(p) + KZG(blinding_factor)
  • code no longer panics when polynomials are evaluated LAGRANGE or LAGRANGE_COSET basis

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • Test TestEvaluation

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

github-actions bot commented Jan 9, 2024

📦 github.com/consensys/gnark-crypto/ecc/bls12-377/fr/fft
TestBitReverse 0s

📦 github.com/consensys/gnark-crypto/ecc/bls12-377/fr/fri
TestFRI 0s

+ verifying wrong opening should fail: OK, passed 10 tests.

📦 github.com/consensys/gnark-crypto/ecc/bls12-377/fr/iop [github.com/consensys/gnark-crypto/ecc/bls12-377/fr/iop.test]

ecc/bls12-377/fr/iop/polynomial.go:371:27: invalid operation: cannot index d.CosetTable (value of type func() ([]fr.Element, error))

📦 github.com/consensys/gnark-crypto/ecc/bls12-377/fr/sis
TestReference 0s

📦 github.com/consensys/gnark-crypto/ecc/bls12-378
TestCrossMultiExpG1 0s

TestEncodeToG1 0s

TestEncoder 0s

TestG1AffineCofactorCleaning 0s

TestG1AffineConversions 0s

TestG1AffineEndomorphism 0s

TestG1AffineInvalidBitMask 0s

TestG1AffineIsOnCurve 0s

TestG1AffineOps 0s

TestG1AffineSerialization 0s

TestG1SqrtRatio 0s

TestG2AffineCofactorCleaning 0s

TestG2AffineConversions 0s

TestG2AffineEndomorphism 0s

TestG2AffineInvalidBitMask 0s

TestG2AffineIsOnCurve 0s

TestG2AffineOps 0s

TestG2AffineSerialization 0s

TestHashToG1 0s

TestIsCompressed 0s

TestMapToCurve1 0s

TestMapToG1 0s

@ThomasPiellard ThomasPiellard marked this pull request as draft January 10, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant