This repository has been archived by the owner on Feb 3, 2024. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabbate19
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
Lgtm, @mxmeinhold reviewed my pagination PR so if they can also see this that would be great
mxmeinhold
suggested changes
May 14, 2022
There was a problem hiding this comment.
whoops, forgot to actually hit review on this.
I agree with the goal of pagination, but I'm a little confused how this looks with regard the the ui, and my concern with #68 also applies here: this leaves no way to ctrl-f through all the quotes
| //Prepare the url with the proper query strings | ||
| let urlParams = new URLSearchParams(window.location.search); | ||
| let speaker = urlParams.get('speaker'); | ||
| let submitter = urlParams.get('submitter'); | ||
| let urlStr = `/additional`; | ||
| let page = urlParams.get('page'); | ||
| let urlStr = `/additional?j`; |
| //Prepare the url with the proper query strings | ||
| let urlParams = new URLSearchParams(window.location.search); | ||
| let speaker = urlParams.get('speaker'); | ||
| let submitter = urlParams.get('submitter'); | ||
| let urlStr = `/additional`; | ||
| let page = urlParams.get('page'); |
There was a problem hiding this comment.
does this ever get used?
Comment on lines
-54
to
+58
| $("#moreQuotes").html(data) | ||
| $("#moreQuotes").append(data) |
There was a problem hiding this comment.
a bit unsure of how this looks in practice, could you send some redacted/dev screenshots? otherwise I should be able to throw up a local dev instance at some point soon
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pages to Quotefault so it doesn't load literally every other quote
Pages are size 20