Graphical review skinning #225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # client/app/step-builder/step-builder/step-builder.component.html # client/app/step-builder/step-builder/step-builder.component.scss # client/app/step-builder/step-builder/step-builder.component.ts # client/app/task-builder/task-builder.component.html
aditi-kapur
reviewed
May 17, 2017
| <li class="nav-item ml-sm hidden-sm-down"><a class="nav-link" href="#"><img class="brand_logo" src="assets/images/builder_logo.png"/></a></li> | ||
| <li class="nav-item ml-sm hidden-sm-down"><a class="nav-link" href="#"><h4 class="fw-semi-bold hidden-sm-down">SIMS Builder</h4></a></li> | ||
| <li class="nav-item ml-sm hidden-sm-down"><a class="nav-link" href="#"><img class="brand_logo" src="assets/images/builder_logo_blue.png"/></a></li> | ||
| <li class="nav-item ml-sm hidden-sm-down"><a class="nav-link" href="#"><h4 style="color: #005A8E" class="fw-semi-bold hidden-sm-down">SIMS Builder</h4></a></li> |
There was a problem hiding this comment.
Please move inline style to scss file
There was a problem hiding this comment.
Added New SCSS File. CSS moved.
aditi-kapur
reviewed
May 17, 2017
| @@ -9,7 +9,7 @@ | |||
| <!-- #notifications-dropdown-menu goes here when screen collapsed to xs or sm --> | |||
| </div> | |||
| <!-- main notification links are placed inside of .sidebar-nav --> | |||
| <ul class="sidebar-nav"> | |||
| <ul class="sidebar-nav" style="font-weight: 600;"> | |||
There was a problem hiding this comment.
Please move inline style to scss file
aditi-kapur
reviewed
May 17, 2017
| @@ -1,3 +1,4 @@ | |||
| $card-border-blue:#5876B9; | |||
There was a problem hiding this comment.
Please move variable to _variables.scss
There was a problem hiding this comment.
Color removed.
aditi-kapur
reviewed
May 17, 2017
| $progressbar-connector: #C1C1C1; | ||
| $brand-info: #5dc4bf; | ||
| $gray-dark: #343434; | ||
|
|
There was a problem hiding this comment.
Please move variable to _variables.scss
There was a problem hiding this comment.
Variable was not added in this pull request.
Moving corresponding CSS to SCSS file.
| @@ -14,7 +14,7 @@ declare var jQuery: any; | |||
| '[class.app]' : 'true', | |||
| id: 'app' | |||
| }, | |||
| styles:['.fixed_navbar{position:fixed;} .searchForm{margin-top:2px;}'] | |||
| styles:['.fixed_navbar{position:fixed;} .searchForm{margin-top:2px;} .sidebar{background-color: #383E4B}'] | |||
There was a problem hiding this comment.
add scss file and define color as a variable
| ul.sidebar-nav{ | ||
| font-weight: 600; | ||
| } | ||
| .sidebar-nav > li:last-child > a { |
There was a problem hiding this comment.
Color should be defined in variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skinning as per Option 2 of Graphical review.