Fix request to API #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Alliad
commented
Apr 11, 2024
Alliad
commented
- Update schemas
- Regenerate python code for new schemas
- Move api urls to settings
- Fix get pools request'
…ls to settings \nFix get pools request
mantis/blackbox/main.py
Outdated
| osmosis_pools = OsmosisPoolsResponse.parse_raw(response.content) | ||
| else: | ||
| logger.error(f"Response Status Code: {response.status_code}") | ||
| logger.error(f"Error fetching OSMOSIS pools: {response.content}") |
There was a problem hiding this comment.
raise Error in case of not 200 and fail request
|
@Alliad please fail in not 200 and push merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.