Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Tag Domain 생성(#49) #50

Merged
merged 1 commit into from
Feb 12, 2024
Merged

feat: Tag Domain 생성(#49) #50

merged 1 commit into from
Feb 12, 2024

Conversation

soonhankwon
Copy link
Contributor

@soonhankwon soonhankwon commented Feb 5, 2024 •
edited
Loading

  • ✅ PR 제목의 형식을 잘 작성했나요? e.g. feat: PR을 등록한다.
  • ✅ 테스트는 잘 통과했나요?
  • ✅ 빌드는 성공했나요?
  • ✅ 불필요한 코드는 제거했나요?
  • ✅ 이슈는 등록했나요?
  • ✅ 라벨은 등록했나요?
  • ✅ 코드 컨벤션은 지켰나요?
  • ✅ pr 워크플로우를 돌려주세요.

작업 내용

  • Tag Entity 구현 및 매핑
  • AuthService 메서드 리팩토링(기능 변경X)

스크린샷

주의사항

Closes #49

@soonhankwon
feat: Tag Domain 생성(#44)
809d67d 
- Tag Entity 구현
+ AuthService Refactor
  - null 체크 메서드 안으로 이동
  - 정적팩터리 메서드 사용
@soonhankwon soonhankwon self-assigned this Feb 5, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
94.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

chea-young
chea-young approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@chea-young chea-young left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! :)

jifrozen0110
jifrozen0110 approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@jifrozen0110 jifrozen0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soonhankwon soonhankwon merged commit a6ada4b into develop Feb 12, 2024
2 checks passed
@soonhankwon soonhankwon deleted the feature/issue-49 branch February 12, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chea-young chea-young chea-young approved these changes

@jifrozen0110 jifrozen0110 jifrozen0110 approved these changes

@BomLee427 BomLee427 Awaiting requested review from BomLee427

Assignees

@soonhankwon soonhankwon

Labels
feat🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] Tag 도메인 생성
3 participants
@soonhankwon @jifrozen0110 @chea-young