Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 47 #48

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Feature/issue 47 #48

merged 5 commits into from
Feb 13, 2024

Conversation

chea-young
Copy link
Contributor

@chea-young chea-young commented Feb 4, 2024 •
edited
Loading

  • ✅ PR 제목의 형식을 잘 작성했나요? e.g. feat: PR을 등록한다.
  • ✅ 테스트는 잘 통과했나요?
  • ✅ 빌드는 성공했나요?
  • ✅ 불필요한 코드는 제거했나요?
  • ✅ 이슈는 등록했나요?
  • ✅ 라벨은 등록했나요?
  • ✅ 코드 컨벤션은 지켰나요?
  • ✅ pr 워크플로우를 돌려주세요.

작업 내용

  • schedule entity 생성

스크린샷

@chea-young
feat: add schedule entity (#47)
5a63b9b 
- 스케줄 엔티티 추가
@chea-young
feat: modify schedule entity (#47)
4f4bec9 
- type 삭제, point 추가
@chea-young
feat: modify schedule entity name (#47)
1c36715 
- mysql 제약에 어긋나는 table/column 명 변경
@chea-young chea-young self-assigned this Feb 4, 2024
@chea-young chea-young linked an issue Feb 4, 2024 that may be closed by this pull request
[BE] Schedule 도메인 생성 #47
Closed
1 task
soonhankwon
soonhankwon reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@soonhankwon soonhankwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작업하시느라 고생하셨습니다:) 한 가지 궁금한것은

  • start_time, end_time이 start_date, end_date를 포함하고 있는것으로 생각되는데, 따로 DB에 분류해서 저장하는 이유가 있으신가요?
  • eg) start_date, end_date 를 프론트에 리턴해줘야하는 경우 start_time, end_time을 formatter를 사용해 YYYY-MM-DD 포맷으로 리턴해줄수 있음

@chea-young
Copy link
Contributor Author

@soonhankwon
ERD 설계에 분리되서 구현하였었는데 순환님이 작성해주신 것과 동일하게 포맷을 분리해서 관리하기 위해서라고 생각하였었습니다 해당 부분 다시 여쭤봐야 겠다고 생각했는데 제가 잊었었네요
해당 부분 여쭤보고 수정 필요하다고 수정하겠습니다! 감사합니다!!

@chea-young chea-young closed this Feb 9, 2024
@chea-young
feat: modify schedule entity name (#47)
c90c67a 
- startTime, endTime 삭제
@chea-young chea-young reopened this Feb 9, 2024
@chea-young
Copy link
Contributor Author

@soonhankwon
말씀해주셨던 부분 하나로 통일해도 좋을 것 같다고 의견 받아서 수정해서 다시 커밋하였습니다!

soonhankwon
soonhankwon approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@soonhankwon soonhankwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다. 고생하셨습니다 :)

@soonhankwon @chea-young
feat: Tag Domain 생성(#44)
d111958 
- Tag Entity 구현
+ AuthService Refactor
  - null 체크 메서드 안으로 이동
  - 정적팩터리 메서드 사용
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues

Measures
0 Security Hotspots
94.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chea-young chea-young merged commit 4d41c81 into develop Feb 13, 2024
2 checks passed
@chea-young chea-young deleted the feature/issue-47 branch February 13, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jifrozen0110 jifrozen0110 jifrozen0110 left review comments

@soonhankwon soonhankwon soonhankwon approved these changes

@BomLee427 BomLee427 Awaiting requested review from BomLee427

Assignees

@chea-young chea-young

Labels
feat🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] Schedule 도메인 생성
3 participants
@chea-young @jifrozen0110 @soonhankwon