Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/issue 9 #10

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Chore/issue 9 #10

merged 4 commits into from
Dec 13, 2023

Conversation

chea-young
Copy link
Contributor

No description provided.

@chea-young
feat: add custom exception. (#9)
4dd3087 
Custom exception 설정을 하기 위한, ErrorCode enum, CustomException, CustomExceptionHandler, ErrorDTO를 생성. CustomException 핸들링을 동작시키기 위한 Security 설정을 추가함.
CustomException 핸들링 동작을 확인할 수 있는 test api 추가 (api/develop/v1/unauthorized, api/develop/v1/bad-request)
@chea-young
feat: change ErrorDTO location (#9)
68a327f 
dto에 error 폴더를 생성 뒤, request/response로 분리하여 관리하는 방법으로 변경
@chea-young chea-young added this to the 1차 웹 오픈 milestone Dec 11, 2023
@chea-young chea-young self-assigned this Dec 11, 2023
@chea-young chea-young linked an issue Dec 11, 2023 that may be closed by this pull request
[BE] Custom Error handling 설정 #9
Closed
4 tasks
jifrozen0110
jifrozen0110 reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@jifrozen0110 jifrozen0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

팀원들 같이 정해보면 좋을것같은 몇부분 리뷰로 함께 달아놨습니다!
함께 논의했으면 좋을 것 같은 부분

  • dto에 record 타입 도입
  • 에러 전에 log.warn 던질지

src/main/java/com/compono/ibackend/common/dto/error/response/ErrorDTO.java Outdated Show resolved Hide resolved
src/main/java/com/compono/ibackend/common/dto/error/response/ErrorDTO.java Outdated Show resolved Hide resolved
src/main/java/com/compono/ibackend/common/dto/error/response/ErrorDTO.java Outdated Show resolved Hide resolved
src/main/java/com/compono/ibackend/common/handler/CustomExceptionHandler.java Show resolved Hide resolved
fix: change code type (Integer -> int) (#9)
48fc981 
code의 값이 null인 경우는 존재하지 않기 때문에 int 타입으로 변경
jifrozen0110
jifrozen0110 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@jifrozen0110 jifrozen0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

soonhankwon
soonhankwon approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@soonhankwon soonhankwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@chea-young
fix: reflect on 지윤's code review (#9, #10)
0dfc96f 
1. ErrorDTO에 detail 부분 삭제
2. 에러 전, log.warn 추가
3. DTO 타입 Record 타입으로 통일
@chea-young
Copy link
Contributor Author

@jifrozen0110
코드 리뷰에 남겨주셨던 부분, 수정 후 커밋 남겨놓았습니다! 리뷰 감사합니다

  1. ErrorDTO에 detail 부분 삭제
  2. 에러 전, log.warn 추가
  3. DTO 타입 Record 타입으로 통일

@chea-young chea-young merged commit ba6e078 into develop Dec 13, 2023
@chea-young chea-young deleted the chore/issue-9 branch December 13, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soonhankwon soonhankwon soonhankwon approved these changes

@rr8602 rr8602 rr8602 approved these changes

@jifrozen0110 jifrozen0110 jifrozen0110 approved these changes

@BomLee427 BomLee427 Awaiting requested review from BomLee427

Assignees

@chea-young chea-young

Labels
env🔧
Projects
None yet
Milestone
1차 사전예약 웹 오픈
Development

Successfully merging this pull request may close these issues.

[BE] Custom Error handling 설정
4 participants
@chea-young @jifrozen0110 @rr8602 @soonhankwon