Improve CI sync-cac-oscal when rule/var description/options change #13865
+218
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huiwangredhat
force-pushed
the
CI_compare_rule_var_updates
branch
from
fb2d761 to
61c5744
Compare
|
@marcusburghardt @Mab879 Would you like to review this PR? Thank you. Have a good weekend:) |
huiwangredhat
force-pushed
the
CI_compare_rule_var_updates
branch
from
61c5744 to
472766d
Compare
marcusburghardt
requested changes
Sep 8, 2025
There was a problem hiding this comment.
Thanks @huiwangredhat , I have comments on some small details.
huiwangredhat
force-pushed
the
CI_compare_rule_var_updates
branch
3 times, most recently
from
a80f8cc to
db34ea0
Compare
Signed-off-by: Sophia Wang <[email protected]>
huiwangredhat
force-pushed
the
CI_compare_rule_var_updates
branch
from
db34ea0 to
de37e86
Compare
marcusburghardt
merged commit a820c3b
into
ComplianceAsCode:master
131 of 132 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The CI sync-cac-oscal will be triggered when it detects any updates to
controls/profiles/rule/var.Actually, for the
ruleandvarfiles, only therule.description,var.description, andvar.optionscould impact thecomponent-definition. This PR aims to compare the value of rule/var description/options, then do the sync.Review Hints:
Var.options was updated in PR:13820
python utils/compare_rule_var.py --owner ComplianceAsCode --repo content 13820 linux_os/guide/services/ntp/var_multiple_time_pools.var optionsNo updates of rule.description in PR:13150
python utils/compare_rule_var.py --owner ComplianceAsCode --repo content 13150 applications/openshift/logging/audit_log_forwarding_uses_tls/rule.yml description