Upgrade code for Python 3.7 #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it doesn't look like this repo is actively maintained anymore - but thanks for conversion! It might be useful to make an issue as well that links to this PR. |
|
Hi! Sorry − I completely missed this post last August… Wow, I did not even think that anyone would care much about that repo! Thanks for working on it, i’m more than happy to merge this. |
|
Ok, I took some time to fix the build on master and the tests are passing again. However there are test failures under Python3 − would need investigation |
|
There was also an issue with one of the imports in thumbnaildownload.py -> it needs to be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure whether this repository gets still maintained, but I've updated the code to work with Python 3.7.