feat: add essentials_category and main_category#12357
Open
Yourz wants to merge 20 commits intoComfy-Org:masterfrom
Open
feat: add essentials_category and main_category#12357Yourz wants to merge 20 commits intoComfy-Org:masterfrom
Yourz wants to merge 20 commits intoComfy-Org:masterfrom
Conversation
Marked nodes: - Basic: LoadImage, SaveImage, LoadVideo, SaveVideo, Load3D, CLIPTextEncode - Image Tools: ImageScale, ImageInvert, ImageBatch, ImageCrop, ImageRotate, ImageBlur - Image Tools/Preprocessing: Canny - Image Generation: LoraLoader - Audio: LoadAudio, SaveAudio Amp-Thread-ID: https://ampcode.com/threads/T-019c2b25-cd90-7218-9071-03cb46b351b3
- SaveGLB (Basic) - GetVideoComponents (Video Tools) - TencentTextToModelNode, TencentImageToModelNode (3D) - RecraftRemoveBackgroundNode (Image Tools) - KlingLipSyncAudioToVideoNode (Video Generation) - OpenAIChatNode (Text Generation) - StabilityTextToAudio (Audio) Amp-Thread-ID: https://ampcode.com/threads/T-019c2b69-81c1-71c3-8096-450a39e20910
The field is used for top-level tabs in the node library, not just the Essentials tab. Rename to main_category to support Partner Nodes, Basic, and other main categories. Amp-Thread-ID: https://ampcode.com/threads/T-019c2b69-81c1-71c3-8096-450a39e20910
Yourz
requested review from
Kosinkadink,
comfyanonymous and
guill
as code owners
Yourz
force-pushed
the
rizz--essential-category
branch
from
ea85cca to
5cd68dd
Compare
Yourz
force-pushed
the
rizz--essential-category
branch
from
5cd68dd to
2ec5489
Compare
Yourz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
essentials_categoryBased on Essentials Nodes Categorization - Implementation Status
essentials_categoryfield to V3 node schema (io.Schema) and legacyESSENTIALS_CATEGORYclass attributeessentials_categoryin/object_infoAPI responsemain_categoryBased on Nodes Proposed New Descriptions
main_categoryfield to V3 node schema and legacyMAIN_CATEGORYclass attributemain_categoryin/object_infoAPI responseMAIN_CATEGORY_OVERRIDESmapping incomfy/node_categories.pyfor nodes that need category reassignmentNode categorization
comfy/node_categories.pywith all essentials and main category constants + override mappingsessentials_categoryandmain_categoryto all core, extras, and API nodesEssentials categories
Main categories
Basics, Model Loading, Generation Setup, Image Processing, Animation & Video, AI Models & Controls, Upscaling & Enhancement, Utilities, Specialized Workflows, Development, Misc, Other
API Node PR Checklist
Scope
Pricing & Billing
If Need pricing update:
QA
Comms