Cleanup references to Flash

[Hipska]

While Flash support is deprecated, the codebase still has a lot of references to Flash.

This PR removes all the swf files and an unused swf library that get's loaded on every page. It deletes a php page with abandoned code. Since it never got referenced, it is better/safer to completely remove it. It also renames the action to load the relation graph as it still got a swf reference.

[piRGoif]

Many thanks, we should have done this long ago !

[piRGoif]

Ok for me, but we will need to do a team review... will keep you posted !

[piRGoif]

Will be reviewed by Romain & Denis

[rquetiez]

I would rather have 'navigate_relations' because 'navigate' is too common and grep is the solely option to connect the dots.

[Hipska]

Or just 'relations', like you have 'details' and 'stimulus' for example?

[rquetiez]

Yes, 'relations' is more meaningful than 'navigate', but I would prefer a more discriminant id like 'view-relations' because this will be helpfull on the long run when searching where this operation is used (and therefore perform a change or cleanup.

[Hipska]

Done

[Molkobain]

Just made a few comment, once the one on the complementary modules is discussed and the small changes on the operation name fixed, it will be all good for me.

Thanks for the cleanup @Hipska 👍

[Molkobain]

All good, thanks @Hipska ! ✌

Obsolete

[Molkobain]

We got a "This branch cannot be rebased safely: Rebasing the commits of this branch on top of the base branch cannot be performed automatically as this would create a different result than a regular merge."

Can you try rebasing your branch on develop? Or is it because your branch have diverged from develop?

[Hipska]

That's why I don't like rebase's.. I checked and don't see any merge conflicts. Is a regular merge not possible instead?

[piRGoif]

Hi @Hipska, Guillaume had an error message but I didn't. I've just done the merge !
Usually we are doing squash & merge, unless we absolutely want to keep the PR branch history - I've done squash here.

[Molkobain]

Thanks @piRGoif !

[Hipska]

Hi, could you please also add the hacktoberfest tag to this repo? Hacktoberfest/hacktoberfest-2020#596

[piRGoif]

This was done here too