improve desktop/calc/find_dialog_spec.js stability #14435
Merged
+6
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait for the actual button element to be enabled, not just the wrapper div. Plausible that SynchronizeDisabledState defers the button's disabled attribute removal via a layouting task. remove searchall[-button] test, doesn't exist in impress and isn't used here anyway. Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I9951232f43cc342691a755e74e5d28e9ea5705f4
Contributor
Author
|
This might help with the calc find tests |
mohit-marathe
deleted the
private/caolan/desktop_calc_find_dialog_stability
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for the actual button element to be enabled, not just the wrapper div. Plausible that SynchronizeDisabledState defers the button's disabled attribute removal via a layouting task.
remove searchall[-button] test, doesn't exist in impress and isn't used here anyway.
Change-Id: I9951232f43cc342691a755e74e5d28e9ea5705f4
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay