CompareChanges view: Update view data inside a layouting task. #14424
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It sets CSS properties. Without this, cursor is misplaced at start. Signed-off-by: Gökay Şatır <[email protected]> Change-Id: Ia889bc033fb3e763b46ece72d6c10ef0b60ed466
caolanm
force-pushed
the
private/gokay/compare-changes-cursor
branch
from
2d3b13a to
86e24be
Compare
vmiklos
approved these changes
Feb 12, 2026
Contributor
vmiklos
left a comment
vmiklos
left a comment
There was a problem hiding this comment.
Looks good. It indeed fixes the problem that entering doc compare mode first has a bad cursor, but gets fixed if the browser window loses focus and gets focus again. This doesn't happen anymore after this change. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It sets CSS properties. Without this, cursor is misplaced at start.
Change-Id: Ia889bc033fb3e763b46ece72d6c10ef0b60ed466
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay