Private/gokay/doc comp shape

[gokaysatir]

• Resolves: #
• Target version: main

Summary

TODO

• ...

Checklist

• I have run make prettier-write and formatted the code.
• All commits have Change-Id
• I have run tests with make check
• I have issued make run and manually verified that everything looks okay
• Documentation (manuals or wiki) has been updated or is not required

[vmiklos]

Looks OK in general, I see that dragging shapes in the doc compare view on the RHS is now better; we used to show the preview on the LHS, which was buggy. Please next time describe in the commit messages what are the steps to reproduce the problem you fix, so it's easier to understand your changes, especially if they introduce regressions in the future -- then we'll need to know how to improve the code so both a new and an old use-case works as the same time. So far none of the 4 commit messages contain such description.

Some other comments:

• svgPosition now contains view coordinates, which made me test the shape anchor overlay, which seems to be buggy. I notice it was bad already before this PR. Seems dragging the shape anchor in Writer now moves the shape? That sounds unexpected.

• that double anchor counting (see inline) comment looks wrong, but I may miss something.

Could you please go through the comments and either address them or comment there in case I misunderstood something? (And then feel free to merge this yourself.) Thanks.

[gokaysatir]

Could you please go through the comments and either address them or comment there in case I misunderstood something? (And then feel free to merge this yourself.) Thanks.

Thanks for checking @vmiklos. I reworded the first commit, added comments where needed and added a condition for the anchor section. Prepared a final commit for changes.