[WIP] cypress: add waitForSlideShowIdle to wait for animations to finish #14417
+48
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohit-marathe
force-pushed
the
private/mohitm/wait-slideshow-idle
branch
from
7f65398 to
cd1551e
Compare
Signed-off-by: Mohit Marathe <[email protected]> Change-Id: Idea03a3abcf0579196001f4e43c3b3a76ad0e109
caolanm
force-pushed
the
private/mohitm/wait-slideshow-idle
branch
from
cd1551e to
2915f9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Idea03a3abcf0579196001f4e43c3b3a76ad0e109
Summary
processToIdledoes not wait for slideshow animations to be rendered.waitForSlideShowIdleis an attempt to determine when the slideshow animation is finished rendering