Add masterpagecurrent_icons in the noteboookbar

[shardulvs]

Change-Id: Id30888c170500bd6dfc369fac6b1efe5da17296d

• Resolves: #
• Target version: main

Summary

TODO

• ...

Checklist

• I have run make prettier-write and formatted the code.
• All commits have Change-Id
• I have run tests with make check
• I have issued make run and manually verified that everything looks okay
• Documentation (manuals or wiki) has been updated or is not required

[eszkadev]

please rebase on top of main and solve conflict

[eszkadev]

please add dedicated type for it in Definitions.Types.ts, it helps as a documentation and prevents mistakes

[eszkadev]

is that loop the only difference we need?
I would suggest to not copy paste code. It's duplicated and change in one instance requires change in other too. Best would be to share a code...

How?

• please use Object Oriented Programming here, and some trick:
• wrap all original functions in a class NotebookbarIconViewList (parent class is more general)
• extract the inner icon view creation (this commented piece) in a separate function which takes array of icon views data
• please create subclass which extends the original one as NotebookbarIconView (single, narrower functionality), change the constructor so it takes regular icon view data and reuse parent class, just convert JSON to your "iconviewlist" format :)

[shardulvs]

removed duplicate code by wrapping notebookbarIconViewList with notebookbarIconView. Let me know if you'd prefer OOP

[eszkadev]

label should be translatable: _( ...text... )

[eszkadev]

Previews are not shown on first opening of a dropdown:
Kooha-2026-02-09-06-16-06.webm

This is caused by eventing design in JSDialog... we need to find inside a component the widget with id matching id of the core widget. Then we call function on it (see executeActionImpl in builder)

On demand rendering requests previews when item is shown. Then when we receive response we need to find the widget. But your new widget is not the thing we will find. We try to apply change in "child iconviews" directly (id=*current*, id= *all*). So we need to be sure these icon views have updateRender method. It was done in:

       commonContainer.updateRenders = iconview.updateRenders = (pos: number) => {
		iconview.updateRendersImpl(pos, data.id, iconview);

		// also update the dropdown (if any);
		const dropdownContainer = JSDialog.GetDropdown(data.id);
		if (dropdownContainer)
			iconview.updateRendersImpl(pos, data.id, dropdownContainer);
	};

but I think the dropdown container id is not good in new case?

[shardulvs]

Previews are not shown on first opening of a dropdown: Kooha-2026-02-09-06-16-06.webm

fixed