Skip to content

browser: a11y: fix button background color to meet 4.5:1 contrast ratio#14161

Open
hcvcastro wants to merge 1 commit intoCollaboraOnline:mainfrom
hcvcastro:pr/main/05
Open

browser: a11y: fix button background color to meet 4.5:1 contrast ratio#14161
hcvcastro wants to merge 1 commit intoCollaboraOnline:mainfrom
hcvcastro:pr/main/05

Conversation

@hcvcastro
Copy link
Member

Change-Id: I0f7e0a17e873d76833496b3844910fd17a0e17f0
Signed-off-by: Henry Castro hcastro@collabora.com

--color-canvas: #f0f0f0;

--color-primary: #0b87e7; /* border-color */
--color-primary: #006bb3; /* border-color */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, but I'm not sure about the necessity of changing the other colors outside of --color-primary

@caolanm
Copy link
Contributor

caolanm commented Feb 1, 2026

I think the failure in the writer manage changes test is because the colors have changed, so the screenshot there is out of date so this pr probably needs to regenerate the screenshot with:

make -C cypress_test UPDATE_SCREENSHOT=true check-desktop writer/manage_changes_dialog_spec.js

@hcvcastro
Copy link
Member Author

I think the failure in the writer manage changes test is because the colors have changed, so the screenshot there is out of date so this pr probably needs to regenerate the screenshot with:

make -C cypress_test UPDATE_SCREENSHOT=true check-desktop writer/manage_changes_dialog_spec.js

Oh, I need to update the new screenshot (it's new to me). Thanks

@caolanm
Copy link
Contributor

caolanm commented Feb 5, 2026

I gave the wrong how-to update the cypress screenshots, that UPDATE_SCREENSHOT is for some other purpose.

Since then there is now a new piece in cypress_test/README about what I think is the right way, the "Updating base screenshots for compareSnapshot tests" section

@hcvcastro
Copy link
Member Author

I gave the wrong how-to update the cypress screenshots, that UPDATE_SCREENSHOT is for some other purpose.

Since then there is now a new piece in cypress_test/README about what I think is the right way, the "Updating base screenshots for compareSnapshot tests" section

Thanks. The base images have been updated.

Change-Id: I0f7e0a17e873d76833496b3844910fd17a0e17f0
Signed-off-by: Henry Castro <hcastro@collabora.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: To Review

Development

Successfully merging this pull request may close these issues.

3 participants