browser: a11y: fix button background color to meet 4.5:1 contrast ratio#14161
browser: a11y: fix button background color to meet 4.5:1 contrast ratio#14161hcvcastro wants to merge 1 commit intoCollaboraOnline:mainfrom
Conversation
| --color-canvas: #f0f0f0; | ||
|
|
||
| --color-primary: #0b87e7; /* border-color */ | ||
| --color-primary: #006bb3; /* border-color */ |
There was a problem hiding this comment.
Makes sense, but I'm not sure about the necessity of changing the other colors outside of --color-primary
|
I think the failure in the writer manage changes test is because the colors have changed, so the screenshot there is out of date so this pr probably needs to regenerate the screenshot with: make -C cypress_test UPDATE_SCREENSHOT=true check-desktop writer/manage_changes_dialog_spec.js |
Oh, I need to update the new screenshot (it's new to me). Thanks |
|
I gave the wrong how-to update the cypress screenshots, that UPDATE_SCREENSHOT is for some other purpose. Since then there is now a new piece in cypress_test/README about what I think is the right way, the "Updating base screenshots for compareSnapshot tests" section |
61464f7 to
fee18df
Compare
Thanks. The base images have been updated. |
fee18df to
42c6710
Compare
Change-Id: I0f7e0a17e873d76833496b3844910fd17a0e17f0 Signed-off-by: Henry Castro <hcastro@collabora.com>
Change-Id: I0f7e0a17e873d76833496b3844910fd17a0e17f0
Signed-off-by: Henry Castro hcastro@collabora.com