refactor: improve translation handling #434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirate-bot
added
the
pr-checklist-incomplete
Soare-Robert-Daniel
added
the
pr-checklist-skip
pirate-bot
added
pr-checklist-complete
abaicus
requested changes
Nov 20, 2024
There was a problem hiding this comment.
@Soare-Robert-Daniel I left some comments regarding how placeholders are treated. Let me know if you have any questions.
abaicus
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pot file: woocommerce-product-addon.pot.zip
Will affect visual aspect of the product
NO
Screenshots
Test instructions
.potfileCheck before Pull Request is ready:
Closes #433