Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for SDK banner #427

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Nov 1, 2024

Summary

Add SDK banner support.

Will affect visual aspect of the product

YES

Screenshots

image

Test instructions

Must be used with https://github.com/Codeinwp/themeisle-sdk/pull/269

  • Set the instance date between 25 NOV and 3 DEC to trigger Black Friday banner
  • You should see the banner on the Library page.
  • You should NOT see the banner if it is not a Blackfriday Interval

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/themeisle/issues/1688

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Nov 1, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Nov 1, 2024
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) labels Nov 1, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Nov 1, 2024

Plugin build for e0e56de is ready 🛎️!

@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as draft November 4, 2024 09:23
Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good but for testing you should also add details on how to change instance date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants