Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Attach Modal visibility #420

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Fix Attach Modal visibility #420

merged 2 commits into from
Oct 17, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Oct 17, 2024

Summary

Display the Attach Modal only on edit action of the Group Fields

Will affect visual aspect of the product

YES

Screenshots

New Group Fields

image

Existing Group Fields

image

Test instructions

  • Attach modal should be visible on the page that creates the group fields
  • It should be visible on the page that in which the group field is already created

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/ppom-pro/issues/497

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Oct 17, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Oct 17, 2024
@pirate-bot
Copy link
Contributor

Plugin build for a500fc8 is ready 🛎️!

@selul
Copy link
Contributor

selul commented Oct 17, 2024

@Soare-Robert-Daniel I don't think this is a solution to hide the feature for new group? Can't we do something that prevent confusion for new users ?

@Soare-Robert-Daniel
Copy link
Contributor Author

@selul is not hiding since the old users did not have this possibility on that page (for products and tags, not categories)

If we want to be always available, we can create some shadow inputs in the fields form that synchronize with the modal and process it on the big save request. (similar to how it was working with the textarea for Categories in the old version)

@selul
Copy link
Contributor

selul commented Oct 17, 2024

ok, we can keep it like this in this case. I don't have either better ideas.

@selul selul merged commit a238d3c into development Oct 17, 2024
7 checks passed
@selul selul deleted the fix/attach-on-new-group branch October 17, 2024 12:46
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 33.0.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants