Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple categories and backward compatibility #418

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

Summary

The separator for saved categories was \r\n and not just \n. Regression introduced in 73ea813#diff-de5716d7b637a0feed0d4f345ffb3971f14f694081d2af8dfc59a4889d152155R596

Changes:

  • Fixed the separator to be \r\n on saving.
  • The parser will work both on \n and \r\n.
  • Do not save tags if they are not present in the request.

Will affect visual aspect of the product

NO

Test instructions

  • Create a group field
  • Attach it to some categories and check if it works.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/ppom-pro/issues/496

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Oct 16, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Oct 16, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Oct 16, 2024

Plugin build for 3603bdf is ready 🛎️!

@Soare-Robert-Daniel Soare-Robert-Daniel force-pushed the fix/categories branch 2 times, most recently from 3bf6658 to 73245ea Compare October 16, 2024 13:56
@Soare-Robert-Daniel Soare-Robert-Daniel changed the title Fix/categories Fix multiple categories and backward compatibility Oct 16, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel merged commit 756122a into development Oct 17, 2024
6 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the fix/categories branch October 17, 2024 09:47
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 33.0.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants