Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image selection for Image Input #415

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Oct 15, 2024

Summary

Regression made on 66bf9e8

Will affect visual aspect of the product

NO

Test instructions

  • Create an Input Image
  • If the Multiple option is not checked, only one image should be selected.
  • If Multiple and Max Image Select are set, the highlighted images will not be more than the value of Max Image Select.

Note

The value of Min Image Select is used only in validation and was never a part of the script workflow. Any problem with this value is a new issue.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/ppom-pro/issues/493

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Oct 15, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Oct 15, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review October 15, 2024 09:34
@pirate-bot
Copy link
Contributor

Plugin build for 37efca5 is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Oct 15, 2024
@selul selul merged commit 37f2e96 into development Oct 15, 2024
9 checks passed
@selul selul deleted the fix/select-images-required branch October 15, 2024 10:26
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 33.0.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants