Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cart item sanitization #310

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Jun 20, 2024

Summary

Instead of rejecting the cart items with HTML elements, we sanitized them. The sanitation will apply to all the field's values.

Note

The HTML fields also send their content to the cart item, which makes any combination of fields to be rejected.

Will affect visual aspect of the product

NO

Test instructions

  • Use the Textarea, File, and HTML PPOM field.
  • In the textarea add some HTML content and add the time to the cart.
  • The item should be added, and all HTML elements of the Textarea and HTML fields content should be stripped down.

Check before Pull Request is ready:

Closes #306

@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label Jun 20, 2024
@pirate-bot
Copy link
Contributor

Plugin build for 6c6b305 is ready 🛎️!

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Jun 20, 2024
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) and removed pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Jun 20, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Jun 20, 2024 that may be closed by this pull request
@Soare-Robert-Daniel Soare-Robert-Daniel merged commit 4c5e913 into development Jun 25, 2024
7 of 9 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the fix/field-sanitization branch June 25, 2024 07:40
@Soare-Robert-Daniel Soare-Robert-Daniel mentioned this pull request Jun 25, 2024
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 32.0.23 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Products are not added to cart
3 participants