Fix infinite file upload popup

[Soare-Robert-Daniel]

Summary

• Added a guard that checks if the instance of Uploader is already initialized. 2f883cc
• Refactor some variable names to express their scope better and eliminate the var keyword.

Context

If the File Input Field is not visible at first, it will go into an infinite initialization loop because of the recursion created by the PostInit event.

Users who are using conditional fields are affected by this problem.

woocommerce-product-addon/js/file-upload.js

Lines 336 to 356 in f512dcc

	PostInit: function() {
	// file_list_preview_containers[file_data_name].html('');
	if ( ! file_list_preview_containers[file_data_name].is(':visible') ) {
	jQuery(document).on('ppom_field_shown', function() {
	jQuery.each(ppom_input_vars.ppom_inputs, function(index, file_input) {
	if (file_input && (file_input.type === 'file' || file_input.type === 'cropper')) {
	if (
	file_input.data_name &&
	file_input.files_allowed &&
	file_input.file_size &&
	file_input.files_allowed
	) {
	ppom_setup_file_upload_input(file_input);
	}
	}
	});
	} );
	}

Notes

I did a little experiment and dumbed the file-upload.js into ChatGPT to see if it could find the problem, and it worked.

Will affect visual aspect of the product

NO

Screenshots

Test instructions

• Use this CSV file to upload the PPOM data: ppom-meta-1715239754.csv
• View the product and test if you can add a file in the input field.

Check before Pull Request is ready:

• I have written a test and included it in this PR
• I have run all tests and they pass
• The code passes when running the PHP CodeSniffer
• Code meets WordPress Coding Standards for PHP, HTML, CSS and JS
• Security and Sanitization requirements have been followed
• I have assigned a reviewer or two to review this PR (if you're not sure who to assign, we can do this step for you)

Closes https://github.com/Codeinwp/ppom-pro/issues/329

[pirate-bot]

Plugin build for f512dcc is ready 🛎️!

• Download PPOM - build 🔗

[preda-bogdan]

maybe we an find a way to also test this.

[pirate-bot]

🎉 This PR is included in version 32.0.23 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀