Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added .ai files to allowed upload mime types #308

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

GrigoreMihai
Copy link
Contributor

@GrigoreMihai GrigoreMihai commented May 28, 2024

Summary

The issue here was that WP is not allowing .Ai files to be uploaded by default.

To fix this I used get_allowed_mime_types() to get the default types allowed by WP then appended '.ai' files to the list before passing it to wp_check_filetype_and_ext() .

The added extensions can also be modified by a filter from now on.

Will affect visual aspect of the product

NO

Screenshots

Test instructions

Try to upload an .ai file. I used this sample to test: https://github.com/newsdev/ai2html/blob/master/sample%20files/sample-ai-file.ai .

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/ppom-pro/issues/328.

@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label May 28, 2024
@GrigoreMihai GrigoreMihai added the pr-checklist-skip Allow this Pull Request to skip checklist. label May 28, 2024
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) and removed pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels May 28, 2024
@pirate-bot
Copy link
Contributor

Plugin build for 4fa2895 is ready 🛎️!

@vytisbulkevicius vytisbulkevicius merged commit fb2e2bf into development Jul 1, 2024
7 of 13 checks passed
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 32.0.23 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jul 1, 2024
@selul selul deleted the fix/328 branch September 6, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants