Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide SDK random promo notice #2473

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

girishpanchal30
Copy link
Contributor

Issue https://github.com/Codeinwp/themeisle/issues/1676

Summary

Added the following filter to hide the SDK promo notice.
add_filter( 'themeisle_sdk_ran_promos', '__return_true' );

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Dec 23, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Dec 23, 2024
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 271.41 KB 271.41 KB 0 B (0.00%)
Blocks 1.56 MB 1.56 MB 0 B (0.00%)
CSS 100.89 KB 100.89 KB 0 B (0.00%)
Dashboard 204.59 KB 204.59 KB 0 B (0.00%)
Onboarding 161.1 KB 161.1 KB 0 B (0.00%)
Export Import 97.78 KB 97.78 KB 0 B (0.00%)
Pro 423.65 KB 423.65 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

Plugin build for 187fae0 is ready 🛎️!

@pirate-bot
Copy link
Contributor

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 246.45, firstPaint: 544.9, domContentLoaded: 1519.8, loaded: 1520.55, firstContentfulPaint: 3607.5, firstBlock: 8056.25, type: 15.14, minType: 12.72, maxType: 25.21, typeContainer: 8.86, minTypeContainer: 7.62, maxTypeContainer: 11.18, focus: 35.59, minFocus: 30.77, maxFocus: 44.93, inserterOpen: 23.21, minInserterOpen: 20.99, maxInserterOpen: 28.82, inserterSearch: 0.71, minInserterSearch: 0.61, maxInserterSearch: 0.88, inserterHover: 3.14, minInserterHover: 2.64, maxInserterHover: 6.89, listViewOpen: 140.87, minListViewOpen: 129.81, maxListViewOpen: 154.27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants