Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin down @wordpress/script to support WordPress 6.5 or earlier #2350

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Aug 22, 2024

Closes #2349

Summary

The current version of our react scripts requires a new react package that contains the new runtime for React 19. This is present only on WP 6.6 or higher. Our script loading was ignored because of the missing package in the early versions.

I downgraded and pinned the @wordpress/scrips to the latest version that supports WP 6.5 or earlier. Now, the build files should be working fine.

Reference: https://github.com/WordPress/gutenberg/blob/2cbba93a29600f09f6f95c09f690576b90e79e9f/packages/scripts/CHANGELOG.md#2800-2024-05-31


Test instructions

Test if everything is working fine with the latest WP version and WP 6.5


Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 22, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Aug 22, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Aug 22, 2024
@selul selul removed their request for review August 22, 2024 10:03
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Aug 22, 2024 that may be closed by this pull request
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 271.14 KB 271.38 KB 253 B (0.09%)
Blocks 1.54 MB 1.56 MB 20.56 KB (1.31%)
CSS 100.76 KB 100.87 KB 108 B (0.10%)
Dashboard 212.77 KB 219.93 KB 7.16 KB (3.36%)
Onboarding 160.83 KB 161.11 KB 287 B (0.17%)
Export Import 97.79 KB 97.78 KB -7 B (-0.01%)
Pro 408.22 KB 422.93 KB 14.71 KB (3.60%)

@pirate-bot
Copy link
Contributor

Plugin build for 39d3375 is ready 🛎️!

@rodica-andronache
Copy link

@Soare-Robert-Daniel tested and it's working well 👍

@Soare-Robert-Daniel Soare-Robert-Daniel merged commit eadbed7 into development Aug 22, 2024
21 of 22 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the fix/wp-scripts-version branch August 22, 2024 10:20
@pirate-bot
Copy link
Contributor

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 253.8, firstPaint: 173.1, domContentLoaded: 1597.7, loaded: 1598.55, firstContentfulPaint: 3556.95, firstBlock: 7914.6, type: 13.7, minType: 12.26, maxType: 14.72, typeContainer: 8.83, minTypeContainer: 7.29, maxTypeContainer: 11, focus: 31.95, minFocus: 28.65, maxFocus: 37.2, inserterOpen: 22.48, minInserterOpen: 20.07, maxInserterOpen: 27.12, inserterSearch: 0.88, minInserterSearch: 0.75, maxInserterSearch: 1, inserterHover: 3.37, minInserterHover: 2.8, maxInserterHover: 4.95, listViewOpen: 146.9, minListViewOpen: 132.49, maxListViewOpen: 162.72

@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All blocks disappear as "Not supported" in latest version
3 participants