Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed popup dismiss issue with recurring visitors option #2347

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

girishpanchal30
Copy link
Contributor

Fix popup dismiss issue with recurring visitors option

Closes https://github.com/Codeinwp/otter-internals#228

Summary

In this PR I've fixed the popup dismiss issue with recurring visitors option.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 20, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Aug 20, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 20, 2024

Bundle Size Diff

Package Old Size New Size Diff
Animations 271.38 KB 271.38 KB 0 B (0.00%)
Blocks 1.56 MB 1.56 MB 83 B (0.01%)
CSS 100.87 KB 100.87 KB 0 B (0.00%)
Dashboard 219.93 KB 219.93 KB 0 B (0.00%)
Onboarding 161.11 KB 161.11 KB 0 B (0.00%)
Export Import 97.78 KB 97.78 KB 0 B (0.00%)
Pro 422.93 KB 422.93 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 20, 2024

Plugin build for 807613d is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 20, 2024

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 242.7, firstPaint: 149.55, domContentLoaded: 1611.1, loaded: 1611.65, firstContentfulPaint: 3576.2, firstBlock: 7913.85, type: 14.33, minType: 12.85, maxType: 21.4, typeContainer: 9.15, minTypeContainer: 7.71, maxTypeContainer: 12.47, focus: 34.31, minFocus: 29.93, maxFocus: 41.04, inserterOpen: 24.22, minInserterOpen: 20.03, maxInserterOpen: 34.32, inserterSearch: 0.88, minInserterSearch: 0.74, maxInserterSearch: 1.07, inserterHover: 3.3, minInserterHover: 2.69, maxInserterHover: 4.44, listViewOpen: 148.5, minListViewOpen: 135.64, maxListViewOpen: 166.15

src/blocks/blocks/popup/save.js Outdated Show resolved Hide resolved
@HardeepAsrani HardeepAsrani merged commit ed9a053 into development Aug 28, 2024
11 checks passed
@HardeepAsrani HardeepAsrani deleted the bugfix/otter-internals/228 branch August 28, 2024 03:53
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants