Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Otter notice in FSE editor for Blocks CSS #2295

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

HardeepAsrani
Copy link
Member

Closes https://github.com/Codeinwp/otter-internals/issues/120 and https://github.com/Codeinwp/otter-internals/issues/194.

Summary

This adds a Notice to Site Editor when Blocks CSS is being used alone. Clicking on the button installs to Otter in a new tab.

Screenshots

Screenshot 2024-08-01 at 2 20 30 AM

Test instructions

  • Confirm the notice appears if:
    • When using Blocks CSS in Site Editor
    • Not inside normal Post Editor or when used as part of Otter

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@HardeepAsrani HardeepAsrani added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jul 31, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jul 31, 2024
@HardeepAsrani
Copy link
Member Author

@ineagu Let me know if you have any feedback on the wording.

@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 263.48 KB 263.48 KB 0 B (0.00%)
Blocks 1.52 MB 1.52 MB 0 B (0.00%)
CSS 92.73 KB 93.18 KB 465 B (0.49%)
Dashboard 195.5 KB 195.5 KB 0 B (0.00%)
Onboarding 153.14 KB 153.14 KB 0 B (0.00%)
Export Import 90.21 KB 90.21 KB 0 B (0.00%)
Pro 361.57 KB 361.57 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 31, 2024

Plugin build for 44aea76 is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 31, 2024

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 240.8, firstPaint: 159.05, domContentLoaded: 1566.65, loaded: 1567.5, firstContentfulPaint: 3510.8, firstBlock: 6802, type: 12.36, minType: 10.73, maxType: 14.55, typeContainer: 9.09, minTypeContainer: 7.51, maxTypeContainer: 11.23, focus: 34.33, minFocus: 27.86, maxFocus: 53.19, inserterOpen: 24.11, minInserterOpen: 20.95, maxInserterOpen: 32.82, inserterSearch: 0.76, minInserterSearch: 0.61, maxInserterSearch: 0.92, inserterHover: 2.93, minInserterHover: 2.53, maxInserterHover: 3.86, listViewOpen: 146.33, minListViewOpen: 135.75, maxListViewOpen: 165.15

@ineagu
Copy link
Contributor

ineagu commented Aug 1, 2024

looks great.

@HardeepAsrani HardeepAsrani merged commit 4fbbfdb into development Aug 1, 2024
11 checks passed
@HardeepAsrani HardeepAsrani deleted the fix/issue-120 branch August 1, 2024 19:26
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants