Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added neve sidebar promo in the dashboard #2290

Merged
merged 7 commits into from
Aug 2, 2024
Merged

Added neve sidebar promo in the dashboard #2290

merged 7 commits into from
Aug 2, 2024

Conversation

girishpanchal30
Copy link
Contributor

Closes https://github.com/Codeinwp/otter-internals/issues/178

Summary

I've added the neve theme promo notice in the otter dashboard.
For more details here: https://github.com/Codeinwp/otter-internals/issues/178#issuecomment-2252762277

Screenshots

https://tinyurl.com/2xmck5lk

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label Jul 29, 2024
@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jul 29, 2024
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) and removed pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Jul 29, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 29, 2024 •
edited
Loading

Bundle Size Diff

Package Old Size New Size Diff
Animations 263.53 KB 263.53 KB 0 B (0.00%)
Blocks 1.51 MB 1.51 MB 0 B (0.00%)
CSS 93.23 KB 93.23 KB 0 B (0.00%)
Dashboard 196.5 KB 201.77 KB 5.27 KB (2.68%)
Onboarding 153.19 KB 153.19 KB 0 B (0.00%)
Export Import 90.25 KB 90.25 KB 0 B (0.00%)
Pro 365.23 KB 365.23 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 29, 2024 •
edited
Loading

Plugin build for ee34003 is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 29, 2024 •
edited
Loading

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 239.35, firstPaint: 147.3, domContentLoaded: 1575.65, loaded: 1576.45, firstContentfulPaint: 3529.85, firstBlock: 7815.45, type: 13.37, minType: 10.59, maxType: 17.77, typeContainer: 9.11, minTypeContainer: 8.07, maxTypeContainer: 11.04, focus: 33.97, minFocus: 29.2, maxFocus: 42.86, inserterOpen: 23.09, minInserterOpen: 20.49, maxInserterOpen: 27.28, inserterSearch: 0.74, minInserterSearch: 0.64, maxInserterSearch: 0.89, inserterHover: 3.73, minInserterHover: 2.87, maxInserterHover: 7.9, listViewOpen: 149.24, minListViewOpen: 137.04, maxListViewOpen: 162.71

@harshitarora-in
Copy link
Contributor

harshitarora-in commented Jul 29, 2024 •
edited by girishpanchal30
Loading

Hi @girishpanchal30 It is looking good. Please make the following changes:

  • When clicking on the preview theme, I am facing the following error: https://vertis.d.pr/i/d92ZoU

  • Please use the updated screenshot from Figma as the speed scores are not clearly visible.

HardeepAsrani
HardeepAsrani reviewed Jul 29, 2024
View reviewed changes
Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ineagu Here, do you think we should take some precautions to avoid showing this notice if user is using any other themes by us, like Raft or Neve FSE?

@girishpanchal30
Copy link
Contributor Author

@harshitarora-in Fixed both mentioned issues with the latest commit.

@harshitarora-in
Copy link
Contributor

@harshitarora-in Fixed both mentioned issues with the latest commit.

@girishpanchal30 Please align the image in the middle.

@girishpanchal30
Copy link
Contributor Author

@harshitarora-in Fixed, Please check with the latest commit.

@harshitarora-in
Copy link
Contributor

@harshitarora-in Fixed, Please check with the latest commit.

Looks good! Please check the below 2 screenshots:

@girishpanchal30
Copy link
Contributor Author

@harshitarora-in Fixed, Please check with the latest build zip.

@harshitarora-in
Copy link
Contributor

@girishpanchal30 looks good now, Thanks!

@HardeepAsrani HardeepAsrani merged commit 8e1132f into development Aug 2, 2024
11 checks passed
@HardeepAsrani HardeepAsrani deleted the feat/neve-promo-notice branch August 2, 2024 17:51
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HardeepAsrani HardeepAsrani HardeepAsrani left review comments

Assignees
No one assigned
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@girishpanchal30 @pirate-bot @harshitarora-in @HardeepAsrani