Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent rank math filter to erase previous content #1956

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Nov 2, 2023

Closes #1955

Summary

Make the custom 'rank_math_content' filter to return its given content by params.

⚠️ It seems that not given the original content made some condition to show negative.

Screenshots

Without Otter

image

Current version

image

With fix

image


Test instructions

  1. Install MathRank
  2. Make a page and check the store.
  3. Install Otter with the fix and score that should remain the same or go higher*.

*The code was initially added to detect Post blocks. Check this #1874


Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Nov 2, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Nov 2, 2023 that may be closed by this pull request
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review November 2, 2023 14:56
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 275.01 KB 275.01 KB 0 B (0.00%)
Blocks 1.48 MB 1.48 MB 51 B (0.00%)
CSS 89.3 KB 89.3 KB 0 B (0.00%)
Dashboard 132.27 KB 132.27 KB 0 B (0.00%)
Export Import 87.21 KB 87.21 KB 0 B (0.00%)
Pro 346.65 KB 346.65 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

Plugin build for 0171f32 is ready 🛎️!

@pirate-bot
Copy link
Contributor

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 73.54 10.1 75.08 21.05 (60ms) 73.68 (80ms)
Values above 60ms "4 - 65.18, 5 - 79.88, 6 - 85.00, 7 - 75.08, 8 - 74.20, 9 - 82.74, 10 - 82.00, 11 - 72.91, 12 - 74.35, 13 - 78.52, 14 - 79.62, 15 - 74.09, 16 - 87.31, 17 - 81.43, 18 - 79.28"

Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working well now, during the QA we can try to test it with a wide range of blocks with content, like a Section, Column and etc to confirm it works normally.

@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel @HardeepAsrani Tested and the issue is fixed, also tested some blocks and they are not negatively impacting the RankMath score 🚀

@HardeepAsrani HardeepAsrani merged commit 49c6f34 into development Nov 3, 2023
29 checks passed
@HardeepAsrani HardeepAsrani deleted the fix/mathrank branch November 3, 2023 12:08
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added released Indicate that an issue has been resolved and released in a particular version of the product. pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RankMath not working with latest Otter
4 participants