-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Global Defaults option for Heading Block & CSS improvments #1870
Conversation
Bundle Size Diff
|
Plugin build for 5e20ba6 is ready 🛎️!
|
E2E SummaryTyping
Values above 60ms"0 - 93.97, 1 - 60.10, 3 - 77.18, 4 - 68.92, 5 - 66.64, 6 - 65.76, 7 - 69.23, 8 - 71.54, 9 - 67.74, 10 - 63.53, 11 - 66.37, 12 - 66.44, 13 - 71.87, 14 - 66.36, 15 - 68.28, 16 - 66.38, 17 - 71.16, 18 - 64.56" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of code, LGTM. You can get design team's feedback to confirm the functionality is working as they expect it to work.
@mghenciu, if you can help with a review 🙏 |
Looks good, Robert - nice job 🚀 Just a general question. It's still impossible to use the Core controls for Line height, letter spacing, etc? like below |
@mghenciu, yes, we can upgrade the Typography section with ones like in Buttons ℹ️ I recommend putting this as a separate issue, which should include more enhancements. |
@Soare-Robert-Daniel when I change the margin option, the other options ( text color, font family etc ) get reset to the initial value https://www.loom.com/share/9f04181ee4c743d195d81d18d3637011?sid=57dd7e1a-1cd9-4779-8301-90c81ee1ae5a |
@Soare-Robert-Daniel the first issue is fixed.
You can test it here:
|
This will be on hold until #1882 is merged since the new typo comp must also be in the Global Default. |
@Soare-Robert-Daniel thank you for the fixes, everything is working well now 👍 |
🎉 This PR is included in version 2.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes #1490
Summary
🔧 Added Global Defaults controls for Advanced Heading Block.
🖼️ Improved the control alignment. -- This was very time consuming, and getting the selector right was not so obvious when core components have dynamic class generation.
Screenshots
2023-09-18_14-24-47.mp4
Control Alignment Before
Control Alignment After
Test instructions
Checklist before the final review