Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Global Defaults option for Heading Block & CSS improvments #1870

Merged
merged 6 commits into from
Nov 2, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Sep 18, 2023

Closes #1490

Summary

🔧 Added Global Defaults controls for Advanced Heading Block.
🖼️ Improved the control alignment. -- This was very time consuming, and getting the selector right was not so obvious when core components have dynamic class generation.

Screenshots

2023-09-18_14-24-47.mp4

Control Alignment Before

image

Control Alignment After

image

Test instructions


Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Sep 18, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Sep 18, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Sep 18, 2023 that may be closed by this pull request
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review September 18, 2023 11:38
@pirate-bot
Copy link
Contributor

pirate-bot commented Sep 18, 2023

Bundle Size Diff

Package Old Size New Size Diff
Animations 275.01 KB 275.01 KB 0 B (0.00%)
Blocks 1.47 MB 1.47 MB 6.26 KB (0.42%)
CSS 89.3 KB 89.3 KB 0 B (0.00%)
Dashboard 131.28 KB 131.28 KB 0 B (0.00%)
Export Import 87.21 KB 87.21 KB 0 B (0.00%)
Pro 346.54 KB 346.58 KB 39 B (0.01%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Sep 18, 2023

Plugin build for 5e20ba6 is ready 🛎️!

@pirate-bot
Copy link
Contributor

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 68.59 7.33 66.64 5.26 (60ms) 94.74 (80ms)
Values above 60ms "0 - 93.97, 1 - 60.10, 3 - 77.18, 4 - 68.92, 5 - 66.64, 6 - 65.76, 7 - 69.23, 8 - 71.54, 9 - 67.74, 10 - 63.53, 11 - 66.37, 12 - 66.44, 13 - 71.87, 14 - 66.36, 15 - 68.28, 16 - 66.38, 17 - 71.16, 18 - 64.56"

Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of code, LGTM. You can get design team's feedback to confirm the functionality is working as they expect it to work.

@Soare-Robert-Daniel
Copy link
Contributor Author

@mghenciu, if you can help with a review 🙏

@mghenciu
Copy link
Contributor

@mghenciu, if you can help with a review 🙏

Looks good, Robert - nice job 🚀


Just a general question. It's still impossible to use the Core controls for Line height, letter spacing, etc? like below
This could help us save a lot of space in the sidebar

image

@Soare-Robert-Daniel
Copy link
Contributor Author

@mghenciu, yes, we can upgrade the Typography section with ones like in Buttons image


ℹ️ I recommend putting this as a separate issue, which should include more enhancements.

@rodica-andronache
Copy link

@Soare-Robert-Daniel when I change the margin option, the other options ( text color, font family etc ) get reset to the initial value https://www.loom.com/share/9f04181ee4c743d195d81d18d3637011?sid=57dd7e1a-1cd9-4779-8301-90c81ee1ae5a

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Sep 29, 2023
@rodica-andronache
Copy link

rodica-andronache commented Sep 29, 2023

@Soare-Robert-Daniel the first issue is fixed.

  • I've noticed another issue, when you click on Shadow > Enable Text Shadow you get "The editor has encountered an unexpected error." https://vertis.d.pr/v/GwfXzr

You can test it here:

https://thoughtful-toad-u3k3a.vertisite.cloud/wp-admin
user: admin
pass: o7QD1Ch)muEbHiRQ^bn2sH@F

@Soare-Robert-Daniel
Copy link
Contributor Author

This will be on hold until #1882 is merged since the new typo comp must also be in the Global Default.

@rodica-andronache
Copy link

@Soare-Robert-Daniel thank you for the fixes, everything is working well now 👍

@HardeepAsrani HardeepAsrani merged commit 17b9dff into development Nov 2, 2023
10 of 11 checks passed
@HardeepAsrani HardeepAsrani deleted the feat/heading-global-default branch November 2, 2023 06:09
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Bottom Margin option for the Advanced Heading
5 participants