Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nps form #107

Merged
merged 2 commits into from
Feb 6, 2024
Merged

feat: add nps form #107

merged 2 commits into from
Feb 6, 2024

Conversation

HardeepAsrani
Copy link
Member

Summary

This adds NPM survey using the FormBricks app.

Screenshots


Test instructions

  • If your website is older than one day, it should show you the NPS survey. And vice-versa.
  • You can update neve_fse_install option to see how it reacts based on how long plugin has been active.

Closes #104.

Copy link

github-actions bot commented Jan 24, 2024

Plugin build for c12c3a5 is ready 🛎️!

@JohnPixle
Copy link
Contributor

You can update neve_fse_install option to see how it reacts based on how long plugin has been active.

@HardeepAsrani What value should I put in the option? It now has 1706173677 but I dont know what format this is. tried a few things but no luck.

@HardeepAsrani
Copy link
Member Author

@JohnPixle You can use this tool: https://www.epochconverter.com/

You can covert it to anything in past, like a week in past or so.

@JohnPixle
Copy link
Contributor

@HardeepAsrani Thanks!

I am getting very inconsistent results at my end. I created individual demo sites for each one them. But I cant make it work.

Neve FSE

  • Create demo site
  • Install build and activate theme
  • set timestamp to 1701682713
  • I don’t get the NPS, instead I get the banner that encourages the user to post a review/rating.

Riverbank

  • Create demo site
  • Install build and activate theme
  • The NPS banner appears right away despite Riverbanks timestamp being 1706177031, which is today.
  • When I leave the page or refresh, the banner does not appear again (even if I didnt click the close button of the NPS banner)
  • When I change the timestamp to 2 months earlier, the banner does not appear.

Fork

  • Create Demo site
  • Install Fork build and activate theme
  • Set timestamp to 1701682713
  • I don’t get the NPS, instead I get the banner that encourages the user to post a review/rating.

Jaxon

  • Create demo site
  • Set timestamp to 1701682713
  • I don’t get the NPS either.

Can it be Taste WP? Any insights?

@HardeepAsrani
Copy link
Member Author

@JohnPixle Were you on themes page? Or which page in particular?

@JohnPixle
Copy link
Contributor

@HardeepAsrani I tried on several pages. You can try the magic links for the demo sites in my last comment, and see the setups

@HardeepAsrani
Copy link
Member Author

Seems to be working fine for me on a test site. can you confirm the option date?

Screenshot 2024-01-25 at 4 20 23 PM

@JohnPixle
Copy link
Contributor

@HardeepAsrani The date options are correct at my demos.
Can you please look into the options.php configuration to see if there is any other issue?

Admin area URL: https://nevefsenps.s3-tastewp.com/wp-admin
Username: pixle
Password: e6_fo-8vIlw

@HardeepAsrani
Copy link
Member Author

I checked on the website you sent and it seems to work fine.

Screenshot 2024-01-25 at 6 43 36 PM

@JohnPixle
Copy link
Contributor

JohnPixle commented Jan 25, 2024

@HardeepAsrani Yup, still not luck on my end for Jaxon and Fork. I cant make them appear. Tried with incognito as well.

Can you confirm in the environments below?

Jaxon:
Admin area URL: https://jaxonnps.s3-tastewp.com/wp-admin
Username: pixle
Password: 0CAhu_hQeWE

Fork:
Admin area URL: https://forknps.s1-tastewp.com/wp-admin
Username: pixle
Password: caHKrvyHdSg

You can also see in Formbricks, that fork and Jaxon have been displayed only once.

Last but not least, just want to make sure we did not miss this fix spotted by Marius.

Let me know how I can help with that.

@HardeepAsrani
Copy link
Member Author

@JohnPixle I tried and I'm able to get the NPS form on both websites. You should wait a little as it's not instant. Let me know if that works.

@JohnPixle
Copy link
Contributor

@HardeepAsrani ok, let's move on with this then.

The only thing that troubles me is that in the formbricks dashboard, Fork NPS still shows only 1 display. I haven't been able to see it in the demo, but porobably because you previously interacted with it.

Screenshot 2024-01-29 at 10 29 50 AM

Others are good. I guess we can schedule these to be released, and start collecting the data. Do you think you can merge the respective PRs?

Let me know if u need any help with that. We can sync in Slack for planning.

@HardeepAsrani HardeepAsrani merged commit ea41458 into development Feb 6, 2024
6 checks passed
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants